Fix #2147: redirect both java and scala std out/err #2148
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DarkDimius
reviewed
Mar 29, 2017
| try { | ||
| // Do classloading magic and running here: | ||
| val ucl = new URLClassLoader(Array(dir.toURI.toURL)) | ||
| val cls = ucl.loadClass("Test") | ||
| val meth = cls.getMethod("main", classOf[Array[String]]) | ||
|
|
||
| val ps = new PrintStream(printStream) | ||
| System.setOut(ps) |
There was a problem hiding this comment.
this is thread-unsafe
How did this work in the CI before? how did other tests pass?
There was a problem hiding this comment.
Probably because all run tests execute without being interrupted.
There was a problem hiding this comment.
Also, CI didn't fail because of tests - it failed because we restarted the agent (aka slave). New commit makes it safe.
felixmulder
force-pushed
the
topic/fix-#2147
branch
2 times, most recently
from
e23b33e to
0b1cb37
Compare
felixmulder
force-pushed
the
topic/fix-#2147
branch
from
0b1cb37 to
6d852e1
Compare
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.